Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malloc at least one byte in Parallel #2924

Merged
merged 1 commit into from
Aug 14, 2015

Conversation

ronghanghu
Copy link
Member

This seems to be a simple workaround to fix #2922.

I'll merge once Travis CI pass.

@ronghanghu ronghanghu force-pushed the fix-malloc-empty branch 2 times, most recently from 0a761bd to 1d820f7 Compare August 14, 2015 16:25
@thatguymike
Copy link
Contributor

Hrmm, probably better to actually look at the root issue. Seems like on the mallocs we should check layer state. Although this patch will workaround the issue, we should probably have a more general debate on what the behavior should even be training with no learnable params.

@ronghanghu
Copy link
Member Author

Although this patch will workaround the issue, we should probably have a more general debate on what the behavior should even be training with no learnable params.

I agree. It doesn't make sense to me to train without learnable params (maybe someone just want to see the loss of a network? still doesn't quite make sense to me...). Perhaps train without learnable params should be banned in the future?

Since it is a simple 3 line workaround, I'll first merge this, and debates can follow in new issues.

ronghanghu added a commit that referenced this pull request Aug 14, 2015
Malloc at least one byte in Parallel
@ronghanghu ronghanghu merged commit 33e5b39 into BVLC:master Aug 14, 2015
@ronghanghu ronghanghu deleted the fix-malloc-empty branch August 25, 2015 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in newly added multi-gpu code
2 participants